30 points
Community rank #2027
cmunns
VeteranJust Getting Started
MemberLikes (0)
The admin notification doesn't go away even after configuring the Facebook option. I did notice that the operator used in the notification check is an OR so I'm guessing that the plugin doesn't like that we aren't using Twitter in this plugin.
I tried removing using an action, but had no luck
global $Wdcp_AdminPages;
remove_action( 'admin_notices', array( $Wdcp_AdminPages, 'show_nag_messages', 10));
Any thoughts on why the action is not working...or on improving the check so that it can use the && operator here:
if (!$this->data->get_option('fb_app_id') || !$this->data->get_option('tw_api_key')) {
19007 pointsCommunity rank #1Supreme DeityWPMU DEV StaffLifetime member
Support Chimp
(joined March 2010)
Likes (0)
Hey there.
Just looking into your post here, can you please include an image of admin notification you refer to?
At first I thought it was the notification to install the update plugin but reading again you are referring to something generated when not using Twitter?
A screenshot will let me see clearly where we refer to here.
30 pointsCommunity rank #2027VeteranJust Getting Started
Member
(joined June 2011)
Likes (0)
changing the priority of the action didn't work...I know I can change the operator in the plugin code but that seems silly when there is an action that is supposed to do the job from the theme files.
I think for future releases anyway, the operator should change as not all users will want both twitter and facebook configured.
3287 pointsCommunity rank #17Supreme DeityWPMU DEV StaffLifetime member
Developer
(joined April 2011)
Likes (0)
Hi,
Thank you for pointing the issue out, and tracking it down so thoroughly yourself. The latest plugin release (v1.5, just released) should be taking the disabled services into account when triggering the admin notices.
Responses (11)
Support Kangaroo (joined March 2011) Likes (0)
Greetings cmunns,
Thank you for this great question and bringing this significant issue to our attention.
This we will clearly need a coder to answer.
Therefore I will see if I can get the lead developer in here with his invaluable insight into this plugin for his advice/advise for us.
Though this may take a bit longer then a normal ticket, I will try to get him in here asap.
Cheers, Joe
Support Kangaroo (joined March 2011) Likes (0)
Greetings cmunns,
I just realized that the Comments Plus plugin is assigned as the plugin, is this in fact the case?
Please advise.
Cheers, Joe
Member (joined June 2011) Likes (0)
yep that's correct.
Support Chimp (joined March 2010) Likes (0)
Hey there.
Just looking into your post here, can you please include an image of admin notification you refer to?
At first I thought it was the notification to install the update plugin but reading again you are referring to something generated when not using Twitter?
A screenshot will let me see clearly where we refer to here.
Thanks.
Member (joined June 2011) Likes (0)
It's the one that says:
"You need to configure the Comments Plus plugin, you can do so here"
Support Chimp (joined March 2010) Likes (0)
I see now.
You can change the operator to && if you wish.
Or you can alter the priority:
Change the number to a different value to change its priority.
Let me know how you get on.
Member (joined June 2011) Likes (0)
changing the priority of the action didn't work...I know I can change the operator in the plugin code but that seems silly when there is an action that is supposed to do the job from the theme files.
I think for future releases anyway, the operator should change as not all users will want both twitter and facebook configured.
People Person (joined February 2012) Likes (0)
@cmunns I will put this in as a Feature Request to the developer for the plugin.
Thank You!
Member (joined June 2011) Likes (0)
no, thank you!
Member (joined June 2011) Likes (0)
also, I just realized that it also throws an error in the console when not configured...
EDIT: PLEASE REMOVE THE SCREENSHOT AS IT'S THE WRONG IMAGE
Developer (joined April 2011) Likes (0)
Hi,
Thank you for pointing the issue out, and tracking it down so thoroughly yourself. The latest plugin release (v1.5, just released) should be taking the disabled services into account when triggering the admin notices.
Become a member