BUG: humming bird active in upfront edit mode

Ummm...u guys test this?

scenario:
1. multisite subfolders
2. Nginx
3. edit subblog site
4. domain mapped site that doesn't have https set up for mapped domain
5. Edit from https://networkname.com/subblog/?editmode=true

Pretty stand basic stuff...you guys seeing this work?

Please test this on your own system, thanks!

-Ben

  • Rupok

    Hi Ben,

    Thanks for asking. I'm afraid, I don't have a nginx server at this moment but I've asked my colleagues to check this and we will update you as soon as we are done with testing this. However, can you please tell us specifically what to check? Is Upfront Editor not loading? Is it breaking something? Obviously if we see any issue after testing, we will report to our developer right away but if you could share the issues you are having, that would make sure that we are on the same page.

    Please send as much details regarding the issues you are facing as you can. We will also update you with our findings after testing. I'm looking forward to hearing from you and resolving this issue as soon as possible.

    Have a nice day. Cheers!
    Rupok

  • Ben

    First..try testing. PLEASE! Getting a bit frustrated...

    in upfront editmode via: https://networkname.com/subblog/?editmode=true

    It is trying to load the js files via:
    http://mappeddomain.com/blahblahblah/minifiedcombinedfiles.js

    WONT F-ING WORK because page is being loaded from https and my mapped domain doesnt have https for the domain

    SO...why is it not using networkname.com/subblog/blahblh/minifiedcombinedfiles.js

    reviewing code:

    line 305:

    $site_url = str_replace( array( 'http://', 'https://' ), '', get_option('siteurl') );

    get_option('siteurl') ....is depreciated...hmmm....
    ( refer to: https://codex.wordpress.org/Function_Reference/get_option('siteurl') )

    Outputting the value of get_option('siteurl') to my logs reveals it is my mapped domain domain...i'm not sure that's what it should be nor the expected value...(so maybe domain mapping needs to be reviewed?)

    in addition...this line doesn't seem to be checking to see if https is available for the mapped domain...so why is it just putting in there?

    I really think the dev needs to be reviewing this code...as it is SUPER buggy and not ready for people to use quite yet...more testing needs to be occurring on your own templates by staff...i'm just perplexed here.

    Or maybe I have it all wrong. I don't know. But its not working for me..

    Noticing home_url() and site_url() are outputting the same thing...should they be on a subblog website in the multisite environment?

  • Ben

    my hack work around...but would be good for the developer to review the root of these issues as they may reveal why so much stuff is broken in what looks to be overlooked testing environments...that should be pretty standard:

    wp-hummingbird/core/modules/minify/class-minify-group.php

    Something like this needs to be done on the two occasions where scripts are enqueued

    // ben ben start
                            $final_url = $this->get_group_src();
                            if($_GET['editmode'] == 'true') { // && get_current_site()->domain != $_SERVER['HTTP_HOST']) {
                                    $parse_test = parse_url($final_url);
                                    if(get_current_site()->domain != $parse_test['host']) {
                                            $final_url = str_replace($parse_test['host'] . '/', get_current_site()->domain . get_blog_details()->path, $final_url );
                                    }
                            }
                            $final_url = str_replace( 'http://', '//', $final_url);
                            // ben ben end  
    
                            wp_enqueue_script(
                                    $this->group_id,
                                    $final_url, // ben ben $this->get_group_src(),
                                    $dependencies,
                                    null,
                                    $in_footer
                            );
  • Rupok

    Hi Ben,

    Thanks for reporting and sending all these details. I tested the whole thing and after excluding Upfront CSS file and jQuery assets from minification, Upfront Editor loaded fine without any issue. Can you try the same and let us know what happens?

    But I found that minified assets are being loaded under non SSL though the subsite is set with SSL. I'm reporting this to our Humminbird developer as he can give us best idea regarding this. I'm also forwarding him your suggestion to fix this. I believe, he will come up with his valuable suggestion on this soon and we will update you as soon as we get anything from him.

    Please keep in mind, our developers work round the clock and they have to deal with lots of critical issues and other things. So it may take a little while for them to check this and provide a feedback. I appreciate your patience.

    Have a nice day. Cheers!
    Rupok

Thank NAME, for their help.

Let NAME know exactly why they deserved these points.

Gift a custom amount of points.