Issues creating / updating a PopUp

I am having problems creating popups could someone please take a look as i an gaving all kinds of issues.